This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] Fix comment for la_store_sym_names_in_linkage_form_p
- From: Tom Tromey <tom at tromey dot com>
- To: Tom de Vries <tdevries at suse dot de>
- Cc: gdb-patches at sourceware dot org, Pedro Alves <palves at redhat dot com>, Tom Tromey <tom at tromey dot com>, Joel Brobecker <brobecker at adacore dot com>
- Date: Thu, 13 Jun 2019 09:28:43 -0600
- Subject: Re: [RFC] Fix comment for la_store_sym_names_in_linkage_form_p
- References: <7d5e8fca-cbaf-8749-1ba7-bcbad09cda63@suse.de>
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> This patch fixes the comment to reflect the actual situation.
Tom> Any comments?
This is ok. Thanks for doing this.
I saw that this field is only used in a single spot in dwarf2read.c. So
it would also be fine, I think, to remove it entirely and just check the
languages there -- that's done all over dwarf2read.c already anyway.
This whole area of storing demangled names is a mess unfortunately.
It needs a big cleanup.
Tom