This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[RFC] Fix comment for la_store_sym_names_in_linkage_form_p
- From: Tom de Vries <tdevries at suse dot de>
- To: gdb-patches at sourceware dot org, Pedro Alves <palves at redhat dot com>, Tom Tromey <tom at tromey dot com>, Joel Brobecker <brobecker at adacore dot com>
- Date: Thu, 13 Jun 2019 15:50:36 +0200
- Subject: [RFC] Fix comment for la_store_sym_names_in_linkage_form_p
Hi,
The comment in gdb/language.h for la_store_sym_names_in_linkage_form_p
states:
...
/* True if the symbols names should be stored in GDB's data structures
for minimal/partial/full symbols using their linkage (aka mangled)
form; false if the symbol names should be demangled first.
...
And for C++, la_store_sym_names_in_linkage_form_p is false.
However, AFAICT, while partial and full symbols are stored mangled,
minimal symbols are stored mangled.
This patch fixes the comment to reflect the actual situation.
Any comments?
Thanks,
- Tom
diff --git a/gdb/language.h b/gdb/language.h
index e7446efa07..f584a7e637 100644
--- a/gdb/language.h
+++ b/gdb/language.h
@@ -265,7 +265,7 @@ struct language_defn
const char *la_name_of_this;
/* True if the symbols names should be stored in GDB's data structures
- for minimal/partial/full symbols using their linkage (aka mangled)
+ for partial/full symbols using their linkage (aka mangled)
form; false if the symbol names should be demangled first.
Most languages implement symbol lookup by comparing the demangled