This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] solib-svr4: Pass down svr4_info as much as possible

From: Tom Tromey <tom at tromey dot com>
To: Simon Marchi <simark at simark dot ca>
Cc: Pedro Alves <palves at redhat dot com>, gdb-patches at sourceware dot org
Date: Fri, 19 Apr 2019 14:03:26 -0600
Subject: Re: [PATCH] solib-svr4: Pass down svr4_info as much as possible
References: <20190409131410.10205-1-palves@redhat.com> <eb02a588-ecd2-1731-bdcc-d929f96994c4@simark.ca> <a5956fe9-65e7-ca40-5947-5846c19d9016@simark.ca>

>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

Simon> While reviewing this patch, I had written the patch below to experiment, and
Simon> while it's not super important, I think it's a good cleanup.

Looks reasonable to me.  I'm very much in favor of reducing dependencies
on globals.

thanks,
Tom

Follow-Ups:
- Re: [PATCH] solib-svr4: Pass down svr4_info as much as possible
  - From: Simon Marchi

References:
- [PATCH] Fix "nosharedlibrary + continue + shared lib event" crash
  - From: Pedro Alves
- Re: [PATCH] Fix "nosharedlibrary + continue + shared lib event" crash
  - From: Simon Marchi
- [PATCH] solib-svr4: Pass down svr4_info as much as possible (was: [PATCH] Fix "nosharedlibrary + continue + shared lib event" crash)
  - From: Simon Marchi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]