This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Print non-Ada unions without crashing

From: Tom Tromey <tromey at adacore dot com>
To: Joel Brobecker <brobecker at adacore dot com>
Cc: Tom Tromey <tromey at adacore dot com>, gdb-patches at sourceware dot org
Date: Fri, 19 Apr 2019 13:22:49 -0600
Subject: Re: [PATCH] Print non-Ada unions without crashing
References: <20190409141814.22604-1-tromey@adacore.com> <20190412143756.GA14942@adacore.com>

>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

>> 2019-04-09  Tom Tromey  <tromey@adacore.com>
>> 
>> * ada-lang.c (ada_is_variant_part, ada_to_fixed_type_1):
>> Check ADA_TYPE_P.
>> (empty_record, ada_template_to_fixed_record_type_1)
>> (template_to_static_fixed_type)
>> (to_record_with_fixed_variant_part): Use INIT_NONE_SPECIFIC.
>> * cp-abi.c (value_rtti_type): Check HAVE_CPLUS_STRUCT.
>> * gdbtypes.h (INIT_NONE_SPECIFIC, ADA_TYPE_P): New
>> macros.
>> 
>> gdb/testsuite/ChangeLog
>> 2019-04-09  Tom Tromey  <tromey@adacore.com>
>> 
>> * gdb.ada/ptype_union.c: New file.
>> * gdb.ada/ptype_union.exp: New file.

Joel> I reviewed this patch, and it looks good to me. Someone else may want
Joel> to take a look at it as well, e.g. for the non-Ada parts?

I'm checking it in now.

Tom

References:
- [PATCH] Print non-Ada unions without crashing
  - From: Tom Tromey
- Re: [PATCH] Print non-Ada unions without crashing
  - From: Joel Brobecker

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]