This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 0/9] #include cleanups
On Tuesday, January 22 2019, Tom Tromey wrote:
>>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
>
> Sergio> On Tuesday, January 22 2019, Tom Tromey wrote:
>>> This series cleans up various #includes, in preparation for sorting.
>>> The patches make sense even if sort isn't desirable, though, as for
>>> the most part they fix latent ordering bugs.
>>>
>>> Tested by the buildbot.
>
> Sergio> I looked at the patches, and they seem good to me. Thanks for doing
> Sergio> this.
>
> Thanks for the review.
>
> I wasn't sure about patch #6, since I was a bit lazy about the
> investigation. So, I went back and took a look.
>
> gcc -E -dD says:
>
> [...]
> # 116 "/usr/include/term.h" 3 4
> [...]
> #define lines CUR Numbers[2]
Thanks for the investigation. Yesterday I grep'ed files from readline
and ncurses, and was on my way to finding this define as well.
> So in the end I think just renaming "lines" in this header is a
> reasonable thing to do.
Yes, it does seem reasonable.
> I'm going to check the series in now.
Thanks,
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/