This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 0/9] #include cleanups
- From: Tom Tromey <tom at tromey dot com>
- To: Sergio Durigan Junior <sergiodj at redhat dot com>
- Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
- Date: Tue, 22 Jan 2019 20:34:34 -0700
- Subject: Re: [PATCH 0/9] #include cleanups
- References: <20190122080445.32658-1-tom@tromey.com> <875zug1nkr.fsf@redhat.com>
>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:
Sergio> On Tuesday, January 22 2019, Tom Tromey wrote:
>> This series cleans up various #includes, in preparation for sorting.
>> The patches make sense even if sort isn't desirable, though, as for
>> the most part they fix latent ordering bugs.
>>
>> Tested by the buildbot.
Sergio> I looked at the patches, and they seem good to me. Thanks for doing
Sergio> this.
Thanks for the review.
I wasn't sure about patch #6, since I was a bit lazy about the
investigation. So, I went back and took a look.
gcc -E -dD says:
[...]
# 116 "/usr/include/term.h" 3 4
[...]
#define lines CUR Numbers[2]
So in the end I think just renaming "lines" in this header is a
reasonable thing to do.
I'm going to check the series in now.
Tom