Re: [PATCH] Define 'EXTERN' for simulation internals

[Simon Marchi <simon dot marchi at polymtl dot ca>]

On 2019-01-12 08:16, Павел Крюков wrote:
> Define 'EXTERN' for simulation internals
>
> If inlining is not supported by compiler, sim-arange.h uses
> EXTERN keyword which is not defined yet. Therefore, we define it
> as 'extern' qualifier.
>
> sim/common/Changelog:
> 2019-01-12  Pavel I. Kryukov  <kryukov@frtk.ru>
>
>         * sim-inline.h: define EXTERN macro
>
> diff --git a/sim/common/sim-inline.h b/sim/common/sim-inline.h
> index e9fb5c7..b215252 100644
> --- a/sim/common/sim-inline.h
> +++ b/sim/common/sim-inline.h
> @@ -324,6 +324,9 @@
>  #define EXTERN_INLINE extern INLINE2
>  #endif
>
> +#ifndef EXTERN
> +#define EXTERN extern
> +#endif
>
>  /* Your compiler's no-return reserved word */

Hi Pavel,

This LGTM.  Would you mind precising the compiler (name and version) and 
copy paste the error message?  I'll include those in the commit message, 
for future reference.

Thanks,

Simon