This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Remove cleanup from remote.c

From: Simon Marchi <simon dot marchi at polymtl dot ca>
To: Tom Tromey <tom at tromey dot com>
Cc: gdb-patches at sourceware dot org
Date: Sun, 06 Jan 2019 20:14:52 -0500
Subject: Re: [PATCH] Remove cleanup from remote.c
References: <20190106201224.16653-1-tom@tromey.com>

On 2019-01-06 15:12, Tom Tromey wrote:

This removes the remaining cleanup from remote.c, by changing
remote_state::buf to be a gdb::char_vector, and then fixing up all the
fallout.  The resulting patch is somewhat ugly, but on the other hand,
it eliminates some possibilities for mistakes.

Regression tested using the
Fedora-x86_64-native-extended-gdbserver-m64 builder on the buildbot.

All of this for a single cleanup :). This is fine with me. I think wecould later get rid of a few ->data() by having some functions take agdb::char_vector or gdb::array_view instead of a char*.


Simon

References:
- [PATCH] Remove cleanup from remote.c
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]