This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix search of debug files for remote debuggee

From: Simon Marchi <simark at simark dot ca>
To: Andrey Utkin <autkin at undo dot io>
Cc: John Baldwin <jhb at freebsd dot org>, gdb-patches at sourceware dot org
Date: Wed, 02 Jan 2019 14:53:55 -0500
Subject: Re: [PATCH] Fix search of debug files for remote debuggee
References: <20181109190940.22554-1-autkin@undo.io> <10046787-753c-f7e0-4386-2b50086ae530@FreeBSD.org> <5c1211f6-0e75-d225-158a-0e6a310b68c7@simark.ca> <20190102181153.GA32677@undo-autkin>

On 2019-01-02 13:11, Andrey Utkin wrote:

On Mon, Dec 24, 2018 at 11:26:05AM -0500, Simon Marchi wrote:

Andrey, I would make a few minor changes to your patch, if you agree:

- Use "startswith" instead of strncmp
- Use strlen instead of magical number 7
- Use ternary operator
- Change variable name "remote" to "target_prefix".

This would be the result:


Thanks for improving the patch.
Everything looks great now. Please apply.


Thanks, I just pushed it.

Simon

References:
- Re: [PATCH] Fix search of debug files for remote debuggee
  - From: Andrey Utkin

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]