This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix search of debug files for remote debuggee
- From: Andrey Utkin <autkin at undo dot io>
- To: Simon Marchi <simark at simark dot ca>
- Cc: John Baldwin <jhb at FreeBSD dot org>, gdb-patches at sourceware dot org
- Date: Wed, 2 Jan 2019 18:11:53 +0000
- Subject: Re: [PATCH] Fix search of debug files for remote debuggee
- References: <20181109190940.22554-1-autkin@undo.io> <10046787-753c-f7e0-4386-2b50086ae530@FreeBSD.org> <5c1211f6-0e75-d225-158a-0e6a310b68c7@simark.ca>
On Mon, Dec 24, 2018 at 11:26:05AM -0500, Simon Marchi wrote:
> Andrey, I would make a few minor changes to your patch, if you agree:
>
> - Use "startswith" instead of strncmp
> - Use strlen instead of magical number 7
> - Use ternary operator
> - Change variable name "remote" to "target_prefix".
>
> This would be the result:
Thanks for improving the patch.
Everything looks great now. Please apply.