This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
+reminder+ Don't build readline/libreadline.a, when --with-system-readline is supplied
- From: Дилян Палаузов <dilyan dot palauzov at aegee dot org>
- To: gdb-patches at sourceware dot org
- Date: Mon, 31 Dec 2018 12:18:32 +0000
- Subject: +reminder+ Don't build readline/libreadline.a, when --with-system-readline is supplied
- References: <a2195fc03d1cc1629afa7ac28922f239ac3d705f.camel@aegee.org>
On Wed, 2018-12-12 at 07:46 +0000, Дилян Палаузов wrote:
> https://sourceware.org/bugzilla/show_bug.cgi?id=18632
>
> The bundled libreadline is always built, even if the system is
> ./configure'd --with-system-readline and the build libreadline.a is not
> used.
>
> Proposed patch:
>
> Fix ./configure.ac not to proceed readline/, when --with-system-
> readline is provided
>
> diff --git a/configure.ac b/configure.ac
> index 159f968..adf6dfb 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -253,6 +253,12 @@ if test x$with_system_zlib = xyes ; then
> noconfigdirs="$noconfigdirs zlib"
> fi
>
> +# Don't compile the bundled readline/libreadline.a if --with-system-
> readline
> +# is provided.
> +if test x$with_system_readline = xyes ; then
> + noconfigdirs="$noconfigdirs readline"
> +fi
> +
> # some tools are so dependent upon X11 that if we're not building with
> X,
> # it's not even worth trying to configure, much less build, that tool.