The bundled libreadline is always built, even if the system is ./configure'd --with-system-readline and the build libreadline.a is not used. Proposed patch: Fix ./configure.ac not to proceed readline/, when --with-system-readline is provided diff --git a/configure.ac b/configure.ac index 159f968..adf6dfb 100644 --- a/configure.ac +++ b/configure.ac @@ -253,6 +253,12 @@ if test x$with_system_zlib = xyes ; then noconfigdirs="$noconfigdirs zlib" fi +# Don't compile the bundled readline/libreadline.a if --with-system-readline +# is provided. +if test x$with_system_readline = xyes ; then + noconfigdirs="$noconfigdirs readline" +fi + # some tools are so dependent upon X11 that if we're not building with X, # it's not even worth trying to configure, much less build, that tool.
This seems good, but since the top-level configury is canonically maintained in gcc, the patch should go to gcc-patches.
GCC do not use readline, why shall it integrate this snippet?
(In reply to dilyan.palauzov@aegee.org from comment #2) > GCC do not use readline, why shall it integrate this snippet? The top-level configure+Makefile code is maintained in the gcc repository, then sync'd over to binutils-gdb. So even though gcc doesn't use this, it has this code in it.
I submitted https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87741 .
I filled https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87741 and then sent to the mailing list gcc-patches https://gcc.gnu.org/ml/gcc-patches/2018-10/msg01760.html , https://gcc.gnu.org/ml/gcc-patches/2018-11/msg01331.html and https://gcc.gnu.org/ml/gcc-patches/2018-12/msg00260.html . The answers https://gcc.gnu.org/ml/gcc-patches/2018-12/msg00297.html and https://gcc.gnu.org/ml/gcc-patches/2018-12/msg00299.html suggest to deal with the patch within GDB, not GCC.
Ok, sorry about that. My understand has long been that changes should be made in gcc and then sync'd to gdb -- and that bidirectional syncing was to be avoided. It seems gcc disagrees :-) Can you send your patches to gdb-patches, then? See the gdb contribution checklist: https://sourceware.org/gdb/wiki/ContributionChecklist
I believe this fix was checked in.
(In reply to Tom Tromey from comment #7) > I believe this fix was checked in. Yes https://sourceware.org/git/?p=binutils-gdb.git;a=commit;f=configure.ac;h=69961a84c9b3744a10248fb6cbccc3c688a1e0a5
Unfixed by commit 228cf97dd3c ("Merge configure.ac from gcc project").
Reapplied in gdb. Now let's not close this one before we've propagated to gcc.
(In reply to Tom de Vries from comment #10) > Reapplied in gdb. Now let's not close this one before we've propagated to > gcc. Done: https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=36ba985145ffa8e2078033fc1f1cf22851707a8e Marking fixed again. Keeping milestone 8.3 because releases are not affected.