This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

pushed: [RFA] Move copy_bitwise unittests to own unittest file


> > gdb/ChangeLog:
> > 
> >         * unittests/copy_bitwise-selftests.c: New file.
> >         * utils.c (selftests::bits_to_str, selftests::check_copy_bitwise)
> >         (selftests::copy_bitwise_tests): Delete, moving this code to
> >         unittests/copy_bitwise-selftests.c instead.
> >         (_initialize_utils): Do not register copy_bitwise tests.
> >         * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add
> >         unittests/copy_bitwise-selftests.c.
> > 
> > Tested on x86_64-linux using the official testsuite, but also by
> > verifying that "maintenance selftests" still runs the copy_bitwise
> > tests.
> > 
> > OK to push to master?
> > 
> 
> OK.

Thanks Pedro. Pushed to master. And thanks also to Tom, who pointed
out the issue and even tried to fix it; this started us towards
a nice little cleanup. Really nice :)

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]