This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 3/6] Move mkdir_recursive to common/filestuff.c
- From: Simon Marchi <simon dot marchi at polymtl dot ca>
- To: Tom Tromey <tom at tromey dot com>
- Cc: Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
- Date: Thu, 01 Nov 2018 15:44:44 -0400
- Subject: Re: [PATCH v2 3/6] Move mkdir_recursive to common/filestuff.c
- References: <20181018223100.20693-1-tom@tromey.com> <20181018223100.20693-4-tom@tromey.com> <e334bc95-f650-c4c1-1817-7256636eb2f1@ericsson.com> <6a239617-b748-0a9f-185b-2adcb19c50bc@ericsson.com> <87efc7nohb.fsf@tromey.com> <f062185a-be33-7966-eced-5e547c373966@ericsson.com> <875zxinoo9.fsf@tromey.com>
On 2018-10-31 11:03, Tom Tromey wrote:
"Simon" == Simon Marchi <simon.marchi@ericsson.com> writes:
It would be normal to look at TMPDIR on unix systems.
Simon> Ah, indeed. How is it with this little fixup on top of the
patch?
Seems reasonable, thanks!
Simon> + char *tmp = getenv ("TMPDIR");
A tiny nit: you can use const char * here.
Tom
Pushed with that fixed, thanks!
Simon