Re: Upgrading readline

[Tom Tromey <tom at tromey dot com>]

>>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:

Eli> The Readline version reportedly doesn't work with newer versions of
Eli> Windows, so I think we should ask upstream Readline to use the newer
Eli> code we have in GDB.

I sent a note to bug-readline with the patch.

>> I don't know the difference between __DJGPP__, __MSDOS__, and
>> __GO32__

Eli> They are all equivalent, so I suggest to change them all to use
Eli> __DJGPP__, unless there's some reason not to.

>> the sources also check __MINGW32__, _WIN32, and __CYGWIN__ at
>> places.

Eli> These are unrelated to DOS/DJGPP/GO32, they are for MinGW builds and
Eli> Cygwin builds.

When I did the merge, these changes disappeared, so maybe I was
misreading the diffs somehow.  Or maybe I did the merge wrong, hard to
say.

What I did is make a new git repository and made a branch based on
readline 6.2 patch 1 -- the gdb base revision.  Then I copied the
readline sources from the gdb repository on top of that and committed
it.  Finally, I did a git merge from readline 7.0 patch 5 and fixed up
the conflicts.

You can see the resulting repository here:

    https://github.com/tromey/gdb-readline/tree/gdb-readline

Future merges can be done this way pretty easily, either by just
recreating this process, or by cloning the repository and merging from
the latest readline.

readline 8 is in testing, so perhaps it would be good to try that to see
if there are any new readline bugs affecting gdb.

Tom