This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Upgrading readline
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Tom Tromey <tom at tromey dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Sat, 29 Sep 2018 16:53:05 +0300
- Subject: Re: Upgrading readline
- References: <87efdcikqi.fsf@tromey.com>
> From: Tom Tromey <tom@tromey.com>
> Date: Sat, 29 Sep 2018 05:52:37 -0600
>
> input.c, readline:
> +int
> +win32_isatty (int fd)
> +{
> + return (_isatty (fd) ? ((((long) (HANDLE) _get_osfhandle (fd)) & 3) == 3) : 0);
> +}
The Readline version reportedly doesn't work with newer versions of
Windows, so I think we should ask upstream Readline to use the newer
code we have in GDB.
> I don't know the difference between __DJGPP__, __MSDOS__, and
> __GO32__
They are all equivalent, so I suggest to change them all to use
__DJGPP__, unless there's some reason not to.
> the sources also check __MINGW32__, _WIN32, and __CYGWIN__ at
> places.
These are unrelated to DOS/DJGPP/GO32, they are for MinGW builds and
Cygwin builds.
Thanks for doing this.