This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 09/10] Move register_dump to regcache-dump.c

From: Yao Qi <qiyaoltc at gmail dot com>
To: Simon Marchi <simon dot marchi at polymtl dot ca>
Cc: GDB Patches <gdb-patches at sourceware dot org>
Date: Wed, 21 Feb 2018 13:58:59 +0000
Subject: Re: [PATCH 09/10] Move register_dump to regcache-dump.c
Authentication-results: sourceware.org; auth=none
References: <1517999572-14987-1-git-send-email-yao.qi@linaro.org> <1517999572-14987-10-git-send-email-yao.qi@linaro.org> <9c0e590fd8e1d5d54a426aefe7c78650@polymtl.ca> <CAH=s-PO4iN2sSSm-kv9USnx3u6mjigQ2X1kp1JMG4urq0_L=Fw@mail.gmail.com> <ead1cc4666c2644dc3c740f60ee87d24@polymtl.ca>

On Wed, Feb 21, 2018 at 12:57 PM, Simon Marchi <simon.marchi@polymtl.ca> wrote:
>>
>> register_dump::dump accesses 'struct regcache_desc', which is declared in
>> regcache.c, so that register_dump::dump can't be moved to
>> regcache-dump.c.
>
>
> Is there any reason we can't move struct regcache_descr to regcache.h?

The reason I didn't move is that I want to keep regcache_descr opaque.
To be clear, I don't mind moving regcache_descr to regcache.h and move
all regcache dump stuff into regcache-dump.{c,h}.

-- 
Yao (齐尧)

Follow-Ups:
- Re: [PATCH 09/10] Move register_dump to regcache-dump.c
  - From: Simon Marchi

References:
- [PATCH 00/10 v2] Remove regcache::m_readonly_p
  - From: Yao Qi
- [PATCH 09/10] Move register_dump to regcache-dump.c
  - From: Yao Qi
- Re: [PATCH 09/10] Move register_dump to regcache-dump.c
  - From: Simon Marchi
- Re: [PATCH 09/10] Move register_dump to regcache-dump.c
  - From: Yao Qi
- Re: [PATCH 09/10] Move register_dump to regcache-dump.c
  - From: Simon Marchi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]