This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 09/10] Move register_dump to regcache-dump.c

From: Simon Marchi <simon dot marchi at polymtl dot ca>
To: Yao Qi <qiyaoltc at gmail dot com>
Cc: GDB Patches <gdb-patches at sourceware dot org>
Date: Wed, 21 Feb 2018 07:57:42 -0500
Subject: Re: [PATCH 09/10] Move register_dump to regcache-dump.c
Authentication-results: sourceware.org; auth=none
References: <1517999572-14987-1-git-send-email-yao.qi@linaro.org> <1517999572-14987-10-git-send-email-yao.qi@linaro.org> <9c0e590fd8e1d5d54a426aefe7c78650@polymtl.ca> <CAH=s-PO4iN2sSSm-kv9USnx3u6mjigQ2X1kp1JMG4urq0_L=Fw@mail.gmail.com>

On 2018-02-21 03:27, Yao Qi wrote:

On Sat, Feb 17, 2018 at 3:50 AM, Simon Marchi <simon.marchi@polymtl.ca>wrote:
I think it would make sense to move the remaining dump-related things(the
register_dump class, the register_dump::dump implementation) to
regcache-dump.c.
register_dump::dump accesses 'struct regcache_desc', which is declaredinregcache.c, so that register_dump::dump can't be moved toregcache-dump.c.


Is there any reason we can't move struct regcache_descr to regcache.h?

Follow-Ups:
- Re: [PATCH 09/10] Move register_dump to regcache-dump.c
  - From: Yao Qi

References:
- [PATCH 00/10 v2] Remove regcache::m_readonly_p
  - From: Yao Qi
- [PATCH 09/10] Move register_dump to regcache-dump.c
  - From: Yao Qi
- Re: [PATCH 09/10] Move register_dump to regcache-dump.c
  - From: Simon Marchi
- Re: [PATCH 09/10] Move register_dump to regcache-dump.c
  - From: Yao Qi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]