This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC][06/19] Target FP: Use print_floating in tdep code
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: uweigand at de dot ibm dot com (Ulrich Weigand)
- Cc: macro at imgtec dot com (Maciej W. Rozycki), gdb-patches at sourceware dot org
- Date: Thu, 5 Oct 2017 19:34:17 +0200 (CEST)
- Subject: Re: [RFC][06/19] Target FP: Use print_floating in tdep code
- Authentication-results: sourceware.org; auth=none
Hi Maciej,
> > Also I find the new formatting of `info all-registers' output
> > functionally regressed (rather than merely "changed a bit"), e.g.:
> [...]
> > I think we need to get the ability to align output (previously achieved
> > with formatters, i.e. "%-17.9g" and "%-24.17g") restored; frankly I find
> > the new format unreadable, which makes me consider it unacceptable.
>
> I see, this really doesn't look good. It shouldn't be very difficult
> to fix, since in part 7 of the series I actually introduce routines
> to provide *formatted* output as well. So I think I'll prepare an
> updated patch set that moves patch 6 after patch 7 and uses those
> formatted print routines in the MIPS back-end. Once I've done that,
> it would be good if you could re-run your tests to make sure the
> regression is really fixed.
I've now posted an updated patch set just for the target FP printing
changes. This now applies directly on top of current mainline:
https://sourceware.org/ml/gdb-patches/2017-10/msg00121.html
https://sourceware.org/ml/gdb-patches/2017-10/msg00122.html
https://sourceware.org/ml/gdb-patches/2017-10/msg00123.html
Can you give it a go on MIPS? Thanks!
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com