This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Fix PR remote/21852: Remote run without specifying a local binary crashes GDB
- From: Sergio Durigan Junior <sergiodj at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>
- Date: Wed, 23 Aug 2017 17:29:04 -0400
- Subject: Re: [PATCH] Fix PR remote/21852: Remote run without specifying a local binary crashes GDB
- Authentication-results: sourceware.org; auth=none
- Authentication-results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
- Authentication-results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=sergiodj at redhat dot com
- Dmarc-filter: OpenDMARC Filter v1.3.2 mx1.redhat.com AC6E8883BD
- References: <3ef5d58f-6d27-8f07-b45d-db7f883837a4@redhat.com> <20170823173608.17654-1-sergiodj@redhat.com> <5f5fd8bf-2a6a-f98e-71e3-3c3ff4c03c8e@redhat.com>
On Wednesday, August 23 2017, Pedro Alves wrote:
> On 08/23/2017 06:36 PM, Sergio Durigan Junior wrote:
>
>> A testcase is provided. Regtested on buildbot.
>
> Looks good to me. A question below.
>
>> gdb/ChangeLog:
>> 2017-08-23 Pedro Alvex <palves@redhat.com>
>
> Love my new name, thanks. :-)
Sigh. Sorry, fixed.
>> + # Let's start gdbserver in extended-remote mode now.
>> + set res [gdbserver_start "--multi" ""]
>> + set gdbserver_protocol [lindex $res 0]
>> + if { [string first "extended-" $gdbserver_protocol] != 0} {
>> + set gdbserver_protocol "extended-$gdbserver_protocol"
>> + }
>> + set gdbserver_gdbport [lindex $res 1]
>> + set use_gdb_stub 0
>
> I guess this can't use gdbserver_start_extended because that
> somehow assumes you're starting with a binary? Can you add
> a comment?
Exactly. And sure, I added a comment.
Pushed:
87215ad1651ca3094d813eae06233fd7259b37e5
Thanks,
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/