This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix PR remote/21852: Remote run without specifying a local binary crashes GDB


On 08/23/2017 06:36 PM, Sergio Durigan Junior wrote:

> A testcase is provided.  Regtested on buildbot.

Looks good to me.  A question below.

> gdb/ChangeLog:
> 2017-08-23  Pedro Alvex  <palves@redhat.com>

Love my new name, thanks.  :-)

> +    # Let's start gdbserver in extended-remote mode now.
> +    set res [gdbserver_start "--multi" ""]
> +    set gdbserver_protocol [lindex $res 0]
> +    if { [string first "extended-" $gdbserver_protocol] != 0} {
> +	set gdbserver_protocol "extended-$gdbserver_protocol"
> +    }
> +    set gdbserver_gdbport [lindex $res 1]
> +    set use_gdb_stub 0

I guess this can't use gdbserver_start_extended because that
somehow assumes you're starting with a binary?  Can you add
a comment?

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]