This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v6 1/5] tdesc: handle arbitrary strings in tdesc_register_in_reggroup_p
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Stafford Horne <shorne at gmail dot com>
- Cc: GDB patches <gdb-patches at sourceware dot org>, Openrisc <openrisc at lists dot librecores dot org>, Franck Jullien <franck dot jullien at gmail dot com>
- Date: Tue, 09 May 2017 15:21:43 +0100
- Subject: Re: [PATCH v6 1/5] tdesc: handle arbitrary strings in tdesc_register_in_reggroup_p
- Authentication-results: sourceware.org; auth=none
- References: <cover.1493038197.git.shorne@gmail.com> <cover.1493038197.git.shorne@gmail.com> <dbd35ae7e8f9ca8db89dd14b81119d3eb50afb98.1493038197.git.shorne@gmail.com>
Stafford Horne <shorne@gmail.com> writes:
>
> if (reggroup == general_reggroup)
> return general_p;
> +
> + if (strcmp (reg->group, reggroup_name (reggroup)) == 0)
> + return 1;
> +
> }
I read the patch again, and find that we can replace the whole block in
"if (reg != NULL && reg->group != NULL)" with the code this patch adds,
like this,
if (reg != NULL && reg->group != NULL
&& (strcmp (reg->group, reggroup_name (reggroup)) == 0))
return 1;
--
Yao (齐尧)