This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On 2017-05-09 09:14, Wiederhake, Tim wrote:
Otherwise, it LGTM. I'm not familiar with the btrace specificcomputations, but it made sense to me. I trust that you guys know whatyou are doing and have tested it enough :).I tested the patches on i686 and x86_64 -- maybe I should have mentioned that.
Great, thanks.
If I understand correctly, btrace_function::number is 1-based? If so, it would be good to mention it somewhere (if it's not already, but I couldn't find it).See the comment on btrace_thread_info::functions :).
Ah ok, it comes later in the series. I didn't have time to go that far yet. I suggest throwing a "1-based" in the doc of btrace_function::number, because that's where I would instinctively look for the meaning of that field:
/* The 1-based index of the function segment in BTINFO->FUNCTIONS. */ Thanks, Simon
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |