This is the mail archive of the
mailing list for the GDB project.
Re: [PATCH v3 04/12] btrace: Use function segment index in call iterator.
On 2017-05-09 09:14, Wiederhake, Tim wrote:
Otherwise, it LGTM. I'm not familiar with the btrace specific
computations, but it made sense to me. I trust that you guys know
you are doing and have tested it enough :).
I tested the patches on i686 and x86_64 -- maybe I should have
If I understand correctly, btrace_function::number is 1-based? If so,
it would be good to mention it somewhere (if it's not already, but I
couldn't find it).
See the comment on btrace_thread_info::functions :).
Ah ok, it comes later in the series. I didn't have time to go that far
yet. I suggest throwing a "1-based" in the doc of
btrace_function::number, because that's where I would instinctively look
for the meaning of that field:
/* The 1-based index of the function segment in BTINFO->FUNCTIONS. */