This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA 14/20] Use gdbpy_enter in gdbpy_before_prompt_hook

From: Tom Tromey <tom at tromey dot com>
To: Pedro Alves <palves at redhat dot com>
Cc: Tom Tromey <tom at tromey dot com>, gdb-patches at sourceware dot org
Date: Sat, 12 Nov 2016 10:04:26 -0700
Subject: Re: [RFA 14/20] Use gdbpy_enter in gdbpy_before_prompt_hook
Authentication-results: sourceware.org; auth=none
References: <1478816387-27064-1-git-send-email-tom@tromey.com> <1478816387-27064-15-git-send-email-tom@tromey.com> <ac5b01d7-fc83-99aa-a382-f48eba7da746@redhat.com>

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

>> if (prompt != NULL)
>> set_prompt (prompt.get ());

Pedro> I haven't applied the patch locally, but I suspect this set_prompt call
Pedro> could move to the tail of the nested ifs, where you could
Pedro> return EXT_LANG_RC_OK unconditionally, and then the bottom
Pedro> could just unconditionally return EXT_LANG_RC_NOP.

Yes, that's correct.  I'm making this change.

Tom

References:
- [RFA 00/20] more use of C++ in the Python layer
  - From: Tom Tromey
- [RFA 14/20] Use gdbpy_enter in gdbpy_before_prompt_hook
  - From: Tom Tromey
- Re: [RFA 14/20] Use gdbpy_enter in gdbpy_before_prompt_hook
  - From: Pedro Alves

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]