This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/4] Fix annota-input-while-running.exp remote check
- From: Pedro Alves <palves at redhat dot com>
- To: Simon Marchi <simon dot marchi at polymtl dot ca>, gdb-patches at sourceware dot org
- Date: Mon, 11 Apr 2016 19:03:50 +0100
- Subject: Re: [PATCH 2/4] Fix annota-input-while-running.exp remote check
- Authentication-results: sourceware.org; auth=none
- References: <1459912543-15328-1-git-send-email-simon dot marchi at polymtl dot ca> <1459912543-15328-2-git-send-email-simon dot marchi at polymtl dot ca>
On 04/06/2016 04:15 AM, Simon Marchi wrote:
> The comment says that we can't use runto_main here becore it doesn't
> know how to handle annotation. Instead, the test puts a breakpoint at
> main and calls run by hand. Therefore, it can't work with stub targets,
> since they can't "run". The check should be then changed to check the
> use_gdb_stub variable instead of [is_remote target].
>
> But as an alternative, we can just use runto_main and enable annotations
> after, since the "run to main" part is not really part of what we want
> to test.
>
> I also removed the "set test..." line that is unused.
>
I probably copied this from one of the other annotation tests, like
annota1.exp. Some of those do want to do annotation tests
before "run" though.
> gdb/testsuite/ChangeLog:
>
> * gdb.base/annota-input-while-running.exp: Don't check for
> [is_remote target]. Enable annotations after running to main.
> Remove unused "set test..." line.
OK.
Thanks,
Pedro Alves