This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH 4/4] Fix solib-display.exp remote check

This test currently uses [is_remote target] to check if the test is
supported.  This is not quite correct, as you could run the test with an
extended-remote gdbserver configuration and a remote target [1].  The
test uses "run", which makes it inappropriate for stub-like targets, so
that's what it should check instead.

[1] I managed to do it, but the current testsuite code does not make it
    easy to make such a board file...


	* gdb.base/solib-display.exp: Don't check for [is_remote target],
	check for $use_gdb_stub instead.
 gdb/testsuite/gdb.base/solib-display.exp | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.base/solib-display.exp b/gdb/testsuite/gdb.base/solib-display.exp
index 7f65617..42ad08c 100644
--- a/gdb/testsuite/gdb.base/solib-display.exp
+++ b/gdb/testsuite/gdb.base/solib-display.exp
@@ -28,7 +28,7 @@
 # (and thus aren't affected by shared library unloading) are not
 # disabled prematurely.
-if { [skip_shlib_tests] || [is_remote target] } {
+if { [skip_shlib_tests] } {
     return 0
@@ -72,6 +72,11 @@ foreach libsepdebug {NO IN SEP} { with_test_prefix "$libsepdebug" {
     clean_restart $executable
+    # This test uses run, so it's pointless to test on stub targets.
+    if $use_gdb_stub {
+        return 0
+    }
     if ![runto_main] then {
       fail "Can't run to main"
       return 0

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]