This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v8 09/10] Validate symbol file using build-id
- From: Aleksandar Ristovski <ARistovski at qnx dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Mon, 22 Jun 2015 20:40:55 +0000
- Subject: Re: [PATCH v8 09/10] Validate symbol file using build-id
- Authentication-results: sourceware.org; auth=none
- References: <20150614192542 dot 18346 dot 87859 dot stgit at host1 dot jankratochvil dot net> <20150614192655 dot 18346 dot 17075 dot stgit at host1 dot jankratochvil dot net> <20150621101644 dot GA12733 at host1 dot jankratochvil dot net> <D1AD7D6A dot D079%aristovski at qnx dot com> <20150622203700 dot GA25292 at host1 dot jankratochvil dot net>
On 2015-06-22, 4:37 PM, "Jan Kratochvil" <jan.kratochvil@redhat.com> wrote:
>On Mon, 22 Jun 2015 14:55:14 +0200, Aleksandar Ristovski wrote:
>> Minor thing: it seems you did not put space before the comment block,
>>but
>> in the practice most of such blocks are separated by an empty line from
>> the previous.
>> Example:
>> ...
>> }
>> +/* Boolean for command 'set solib-build-id-force'. */
>> ...
>
>I guess it is some mail reading problem. The patch is:
>
>1: }\n
>2: \n
^^^^^^^^
This one appeared to be missing when I viewed the patch, apparently due to
the viewer.
Thanks,
Aleksandar