This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v8 09/10] Validate symbol file using build-id
- From: Aleksandar Ristovski <ARistovski at qnx dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Mon, 22 Jun 2015 12:55:14 +0000
- Subject: Re: [PATCH v8 09/10] Validate symbol file using build-id
- Authentication-results: sourceware.org; auth=none
- References: <20150614192542 dot 18346 dot 87859 dot stgit at host1 dot jankratochvil dot net> <20150614192655 dot 18346 dot 17075 dot stgit at host1 dot jankratochvil dot net> <20150621101644 dot GA12733 at host1 dot jankratochvil dot net>
FWIW, looks good to me.
Minor thing: it seems you did not put space before the comment block, but
in the practice most of such blocks are separated by an empty line from
the previous.
Example:
...
}
+/* Boolean for command 'set solib-build-id-force'. */
...
Thanks,
Aleksandar Ristovski
QNX Software Systems