Re: [PATCH v5 3/9] sim/erc32: Access memory subsystem through struct memsys.

[Mike Frysinger <vapier at gentoo dot org>]

On 03 Apr 2015 22:35, Jiri Gaisler wrote:
> 	* exec.c (dispatch_instruction) : Access memory through common API.

no space before the :

> 	* interf.c (run_sim, sim_close, sim_write, sim_read, flush_windows) : As above.

same here

> 	* sis.h : Define struct memsys as common memory API. Remove declaration of

and here

> --- a/sim/erc32/interf.c
> +++ b/sim/erc32/interf.c
> @@ -37,16 +37,13 @@
>  #define PSR_CWP 0x7
>  
>  extern struct disassemble_info dinfo;
> -extern struct pstate sregs;
>  extern struct estate ebase;
>  
> -extern int      ctrl_c;
>  extern int      nfp;
>  extern int      ift;
>  extern int      rom8;
>  extern int      wrp;
>  extern int      uben;
> -extern int      sis_verbose;

the changelog needs to mention deletion of global vars/prototypes/etc...

sorry, i don't point these things out to be difficult ... it's just that they 
would need to be fixed before merging, and i really really don't want to do it 
myself.
-mike

Attachment: signature.asc
Description: Digital signature