Re: [PATCH v5 2/9] sim/erc32: Use gdb callback for UART I/O when linked with gdb.

[Mike Frysinger <vapier at gentoo dot org>]

On 03 Apr 2015 22:35, Jiri Gaisler wrote:
> 	* erc32 (init_sim, port_init, read_uart, write_uart, flush_uart, uarta_tx,

"erc32.c"

> 	uartb_tx, uart_rx): Use gdb callbacks for console I/O.

i'm seeing more updates to the global scope.  you need to mention each change -- 
include files added/removed, vars added/removed, etc...

> 	* func.c: declare host callback structure

missing (xxx)

> 	* interf.c (run_sim): add -nouartrx switch to disable UART input.

missing sim_callback

> 	* sis.h: declare host callback structure

need to document each new var/struct

> +int dumbio = 0; /* normal, smart, terminal oriented IO by default */

un-inline it, and fix up the comment style.  it also isn't exactly clear ...
make it a declarative statement:
/* Use a non-dumb (normal, smart) terminal I/O by default.  */
-mike

Attachment: signature.asc
Description: Digital signature