This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Increase timeout in watch-bitfields.exp for software watchpoint
- From: Pedro Alves <palves at redhat dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 15 Apr 2015 12:00:03 +0100
- Subject: Re: [PATCH] Increase timeout in watch-bitfields.exp for software watchpoint
- Authentication-results: sourceware.org; auth=none
- References: <1429023644-13403-1-git-send-email-qiyaoltc at gmail dot com> <552D31E4 dot 1080503 at redhat dot com> <86a8yau0qb dot fsf at gmail dot com> <552D48C5 dot 2050002 at redhat dot com> <86618xu4xr dot fsf at gmail dot com>
On 04/15/2015 10:16 AM, Yao Qi wrote:
> Pedro Alves <palves@redhat.com> writes:
>
>> gdb_test etc. always take the max of local, global and board
>> timeouts. In your current patch, the factor is applied after
>> selecting the max of global and board timeouts. So I think that it
>> should be simplest to say that the the factor is applied after determining
>> the maximum between local, global and board timeouts.
>
> OK, I see. You suggested we should do more than what Maciej's patch
> does. In Maciej's patch, local timeout variable isn't considered, and
> we don't have to.
Right, Maciej's patch only applied the factor in code at global
scope, with no local timeout in scope, so it didn't need to consider
it.
> After moving code to a proc, and in order to be align
> with gdb_expect, we need to consider local timeout variable
> additionally. How about the patch below?
Looks good. Thanks!
> +# - the board variable "gdb,timeout",
Probably period instead of comma at the end.
--
Pedro Alves