This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [commit 7.8] [patch+7.8] Fix 7.8 regression: resolve_dynamic_struct: Assertion `TYPE_NFIELDS (type) > 0' (PR 17642)
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: Jan Kratochvil <jan dot kratochvil at redhat dot com>, GDB <gdb-patches at sourceware dot org>
- Date: Mon, 15 Dec 2014 12:02:49 -0800
- Subject: Re: [commit 7.8] [patch+7.8] Fix 7.8 regression: resolve_dynamic_struct: Assertion `TYPE_NFIELDS (type) > 0' (PR 17642)
- Authentication-results: sourceware.org; auth=none
- References: <20141125195444 dot GA3400 at host2 dot jankratochvil dot net> <20141213142351 dot GG5457 at adacore dot com> <20141215150609 dot GA4229 at adacore dot com> <20141215191244 dot GA23577 at host2 dot jankratochvil dot net> <CAMe9rOod8+arBG7T7FgoNpJmF5LhZ5kwqGfLDF-Wx6ESGH3Qog at mail dot gmail dot com> <20141215193658 dot GC5457 at adacore dot com>
On Mon, Dec 15, 2014 at 11:36 AM, Joel Brobecker <brobecker@adacore.com> wrote:
>> I'd like to backport
>>
>> https://sourceware.org/ml/gdb-patches/2014-12/msg00116.html
>>
>> to 7.8 branch.
>
> This is a fairly big patch...
> 1. How bad is performance without it?
It was very bad, like > 100x slower.
> 2. Can you find a binutils maintainer that will vouch that
> this patch is 100% safe?
As the x86 binutils maintainer, do I count?
> The 7.8.2 is in the pipe because we found a number of crippling issues
> in 7.8.1. At this point, we should only consider extra-safe patches,
> or patches that fix issues considered to be blocking the use of 7.8.1.
> For yours to qualify, you'll need to answer both questions above.
>
> --
> Joel
--
H.J.