This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix possible alignment issue with dw2-dir-file-name test case


On 01/17/2014 03:58 PM, Andreas Arnez wrote:
> OK, how about this?
> 
> ----
> Subject: [PATCH] Re-introduce '_start' labels and add alignment in dw2-dir-file-name test case.
> 
> On ppc64-linux a function symbol does not point to code, but to the
> function descriptor.  Thus the previous change for this test case
> broke it:
> 
>       https://sourceware.org/ml/gdb-patches/2014-01/msg00275.html
> 
> This patch reverts to the original method, re-introducing '_start'
> symbols.  In addition, it adds sufficient alignment before the label,
> such that the label never points into an alignment gap.
> 
> testsuite/
> 2014-01-17  Andreas Arnez  <arnez@linux.vnet.ibm.com>
> 
> 	* gdb.dwarf2/dw2-dir-file-name.c (FUNC): Insert alignment and
> 	define "*_start" label.  Make "name" static.
> 
> 	* gdb.dwarf2/dw2-dir-file-name.exp: Replace references to
> 	${name} by references to ${name}_start.

Great! This patch solves all the failures on ppc64.

Thanks a lot, Andreas.

--
Edjunior


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]