This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] PR python/15464 and python/16113

On Wed, Jan 15, 2014 at 4:46 AM, Joel Brobecker <> wrote:
> I have no objection in this case, so I'll defer to Tom in return :).
> The patch is fairly large, in areas where I don't necessarily understand
> all the repercutions. Hence it is good that Tom's OK with it - so
> go head, and push to 7.7.
> By the way, I happened to notice a couple of style violations which
> I just fixed:
> +    {
> +      const char *field_name = TYPE_FIELD_NAME (type, field);
> +      if (field_name[0] != '\0')
> +       {
> Empty line after local declaration.
> +  if (ftype == NULL)
> +    {
> +      PyErr_SetString (PyExc_TypeError,
> +                      _("'type' attribute of gdb.Field object is not a "
> +                        "gdb.Type object."));
> +    }
> No need for the curly braces.

Thanks for fixing these.

> They are obviously not important for the gdb-7.7 branch, unless you
> think there is a chance we might touch this code again in the near
> future, and would want to backport to 7.7. In that case, cherry-picking
> those two commits on the gdb-7.7 branch would help avoiding patching
> conflicts...

I have cherry-picked all three commits into gdb-7.7-branch.  I built
and tested of course, but I hope I did not screw up something else.

Thank you,
Siva Chandra

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]