This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [Patch] PR python/15464 and python/16113
- From: Siva Chandra <sivachandra at google dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: Tom Tromey <tromey at redhat dot com>, gdb-patches <gdb-patches at sourceware dot org>
- Date: Wed, 15 Jan 2014 05:19:28 -0800
- Subject: Re: [Patch] PR python/15464 and python/16113
- Authentication-results: sourceware.org; auth=none
- References: <CAGyQ6gyT_vfZaFPSbBMVn5oZ+awqzEiMXGD5-ffowDdWMPv3uA at mail dot gmail dot com> <CAGyQ6gwgsCuOu_bSVVWumcVKPs3fyB41KS-QDgCafQggpWBHgg at mail dot gmail dot com> <87lhysltqs dot fsf at fleche dot redhat dot com> <CAGyQ6gzuY0Wd4sXb48L2ZCFsP5MCskWPOwxqLAeQNvvoMdacKQ at mail dot gmail dot com> <87ppnvziuw dot fsf at fleche dot redhat dot com> <CAGyQ6gwhR+XV2Hpm4JGBQam3gsP6im4v7i0EcV3Mc0KqnDK8kQ at mail dot gmail dot com> <87ha96y5wa dot fsf at fleche dot redhat dot com> <20140115124617 dot GK4762 at adacore dot com>
On Wed, Jan 15, 2014 at 4:46 AM, Joel Brobecker <brobecker@adacore.com> wrote:
> I have no objection in this case, so I'll defer to Tom in return :).
> The patch is fairly large, in areas where I don't necessarily understand
> all the repercutions. Hence it is good that Tom's OK with it - so
> go head, and push to 7.7.
>
> By the way, I happened to notice a couple of style violations which
> I just fixed:
>
> + {
> + const char *field_name = TYPE_FIELD_NAME (type, field);
> + if (field_name[0] != '\0')
> + {
>
> Empty line after local declaration.
>
> + if (ftype == NULL)
> + {
> + PyErr_SetString (PyExc_TypeError,
> + _("'type' attribute of gdb.Field object is not a "
> + "gdb.Type object."));
> + }
>
> No need for the curly braces.
Thanks for fixing these.
> They are obviously not important for the gdb-7.7 branch, unless you
> think there is a chance we might touch this code again in the near
> future, and would want to backport to 7.7. In that case, cherry-picking
> those two commits on the gdb-7.7 branch would help avoiding patching
> conflicts...
I have cherry-picked all three commits into gdb-7.7-branch. I built
and tested of course, but I hope I did not screw up something else.
Thank you,
Siva Chandra