This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC 28/32] convert to_get_section_table
- From: Pedro Alves <palves at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 14 Jan 2014 19:23:37 +0000
- Subject: Re: [RFC 28/32] convert to_get_section_table
- Authentication-results: sourceware.org; auth=none
- References: <1389640367-5571-1-git-send-email-tromey at redhat dot com> <1389640367-5571-29-git-send-email-tromey at redhat dot com>
Looks fine to me.
> - struct target_section_table *(*to_get_section_table) (struct target_ops *);
> + struct target_section_table *(*to_get_section_table) (struct target_ops *)
> + TARGET_DEFAULT_RETURN (0);
(I noticed now that methods that return a pointer could
say 'TARGET_DEFAULT_RETURN (NULL)' instead of 0. I'm guessing
you wrote 0 in the previous version where TARGET_DEFAULT
would require a digit.)
--
Pedro Alves