This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC 27/32] convert to_insert_mask_watchpoint
- From: Tom Tromey <tromey at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Tue, 14 Jan 2014 12:23:47 -0700
- Subject: Re: [RFC 27/32] convert to_insert_mask_watchpoint
- Authentication-results: sourceware.org; auth=none
- References: <1389640367-5571-1-git-send-email-tromey at redhat dot com> <1389640367-5571-28-git-send-email-tromey at redhat dot com> <52D58CE4 dot 4090105 at redhat dot com>
>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
Pedro> On 01/13/2014 07:12 PM, Tom Tromey wrote:
>> + char *(*to_pid_to_str) (struct target_ops *, ptid_t)
>> + TARGET_DEFAULT_FUNC (dummy_pid_to_str);
Pedro> This use of "dummy" in the default looked odd to me.
Pedro> I'd suggest renaming it to default_pid_to_str (now or at some
Pedro> point), in line with the other default methods.
I made this change.
Tom