This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Split i386_stap_parse_special_token into smaller functions
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Sergio Durigan Junior <sergiodj at redhat dot com>
- Cc: GDB Patches <gdb-patches at sourceware dot org>, Mark Kettenis <kettenis at gnu dot org>
- Date: Sat, 11 Jan 2014 07:02:00 +0400
- Subject: Re: [PATCH] Split i386_stap_parse_special_token into smaller functions
- Authentication-results: sourceware.org; auth=none
- References: <m37gaodxg2 dot fsf at redhat dot com> <20131230031112 dot GC6055 at adacore dot com> <m361px3yzr dot fsf at redhat dot com> <m3ob3jjne1 dot fsf at redhat dot com>
> >> FWIW, this patch looks good to me, and it is IMO a nice improvement
> >> over the current state. But i386-tdep.c is usually under Mark's
> >> responsibility, so let's give him a little bit of time to reply
> >> as well.
> >
> > Ping.
>
> Ping^2.
>
> This patch is pretty simple IMO (just code movement), so maybe it could
> be reviewed by some other maintainer and maybe approved? It's holding a
> fix for a bug :-).
Go ahead and push. I reviewed the patch a second time, and it still
looks good to me.
Thank you, Sergio.
--
Joel