This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
pushed: [RFA 1/2] New GDB/MI command "-info-gdb-mi-command"
- From: Joel Brobecker <brobecker at adacore dot com>
- To: gdb-patches at sourceware dot org
- Date: Tue, 3 Dec 2013 08:06:08 +0400
- Subject: pushed: [RFA 1/2] New GDB/MI command "-info-gdb-mi-command"
- Authentication-results: sourceware.org; auth=none
- References: <528631F2 dot 40408 at redhat dot com> <1384794719-20594-1-git-send-email-brobecker at adacore dot com> <1384794719-20594-2-git-send-email-brobecker at adacore dot com> <83y54lfwrm dot fsf at gnu dot org> <20131119041022 dot GF3481 at adacore dot com> <529C9EC1 dot 2040607 at redhat dot com>
> > gdb/ChangeLog:
> >
> > * mi/mi-cmds.h (mi_cmd_info_gdb_mi_command): Declare.
> > * mi/mi-cmd-info.c (mi_cmd_info_gdb_mi_command): New function.
> > * mi/mi-cmds.c (mi_cmds): Add -info-gdb-mi-command command.
> > * mi/mi-main.c (mi_cmd_list_features): Add "info-gdb-mi-command"
> > field to output of "-list-features".
> >
> > * NEWS: Add entry for new -info-gdb-mi-command.
> >
> > gdb/doc/ChangeLog:
> >
> > * gdb.texinfo (GDB/MI Miscellaneous Commands): Document
> > the new -info-gdb-mi-command GDB/MI command. Document
> > the meaning of "-info-gdb-mi-command" in the output of
> > -list-features.
> >
> > gdb/testsuite/ChangeLog:
> >
> > * gdb.mi/mi-i-cmd.exp: New file.
> >
> > Re-tested on x86_64-linux. OK to commit?
> >
>
> Looks fine to me.
>
> (I don't have a strong opinion about the dash issue.)
>
> > +# First, verify that the debugger correctly advertises support
> > +# for the -info-gdb-mi-command command.
> > +mi_gdb_test "-list-features" \
> > + "\\^done,features=\\\[.*\"info-gdb-mi-command\".*\\\]" \
> > + "-list-features should include \"info-gdb-mi-command\""
>
> Nit, I'd suggest:
>
> "-list-features includes \"info-gdb-mi-command\""
>
Thanks, Pedro. The suggestion does seem better to me too, so I applied
it. Patch now in.
--
Joel