This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 1/2] New GDB/MI command "-info-gdb-mi-command"
- From: Pedro Alves <palves at redhat dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: Eli Zaretskii <eliz at gnu dot org>, gdb-patches at sourceware dot org
- Date: Mon, 02 Dec 2013 14:52:49 +0000
- Subject: Re: [RFA 1/2] New GDB/MI command "-info-gdb-mi-command"
- Authentication-results: sourceware.org; auth=none
- References: <528631F2 dot 40408 at redhat dot com> <1384794719-20594-1-git-send-email-brobecker at adacore dot com> <1384794719-20594-2-git-send-email-brobecker at adacore dot com> <83y54lfwrm dot fsf at gnu dot org> <20131119041022 dot GF3481 at adacore dot com>
On 11/19/2013 04:10 AM, Joel Brobecker wrote:
> Updated patch attached. And for review convenience, I am also attaching
> a diff of the changes I made on top of path #1 (to get to the updated
> patch).
>
> gdb/ChangeLog:
>
> * mi/mi-cmds.h (mi_cmd_info_gdb_mi_command): Declare.
> * mi/mi-cmd-info.c (mi_cmd_info_gdb_mi_command): New function.
> * mi/mi-cmds.c (mi_cmds): Add -info-gdb-mi-command command.
> * mi/mi-main.c (mi_cmd_list_features): Add "info-gdb-mi-command"
> field to output of "-list-features".
>
> * NEWS: Add entry for new -info-gdb-mi-command.
>
> gdb/doc/ChangeLog:
>
> * gdb.texinfo (GDB/MI Miscellaneous Commands): Document
> the new -info-gdb-mi-command GDB/MI command. Document
> the meaning of "-info-gdb-mi-command" in the output of
> -list-features.
>
> gdb/testsuite/ChangeLog:
>
> * gdb.mi/mi-i-cmd.exp: New file.
>
> Re-tested on x86_64-linux. OK to commit?
>
Looks fine to me.
(I don't have a strong opinion about the dash issue.)
> +# First, verify that the debugger correctly advertises support
> +# for the -info-gdb-mi-command command.
> +mi_gdb_test "-list-features" \
> + "\\^done,features=\\\[.*\"info-gdb-mi-command\".*\\\]" \
> + "-list-features should include \"info-gdb-mi-command\""
Nit, I'd suggest:
"-list-features includes \"info-gdb-mi-command\""
--
Pedro Alves