This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Regression for gdb.pascal/* [Re: [RFA 4/4] Constify parse_linesepc]
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Pierre Muller <pierre dot muller at ics-cnrs dot unistra dot fr>
- Cc: Keith Seitz <keiths at redhat dot com>, "gdb-patches at sourceware dot org ml" <gdb-patches at sourceware dot org>, Sergio Durigan Junior <sergiodj at redhat dot com>, Tom Tromey <tromey at redhat dot com>
- Date: Fri, 18 Oct 2013 19:20:32 +0200
- Subject: Re: Regression for gdb.pascal/* [Re: [RFA 4/4] Constify parse_linesepc]
- Authentication-results: sourceware.org; auth=none
- References: <5249C987 dot 50809 at redhat dot com> <87d2no4uim dot fsf at fleche dot redhat dot com> <524BA344 dot 2070802 at redhat dot com> <20131016095743 dot GA17072 at host2 dot jankratochvil dot net> <m3zjq8hnub dot fsf at redhat dot com> <m3vc0wg4yg dot fsf at redhat dot com> <52602A08 dot 4020705 at redhat dot com> <87ob6ntyc4 dot fsf at fleche dot redhat dot com>
On Thu, 17 Oct 2013 22:51:55 +0200, Tom Tromey wrote:
> >>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
>
> Keith> There are two little sections of code, though, which violate
> Keith> const-ness of the input, and I've removed those, since they don't
> Keith> seem necessary. [This is the two loops that deal with changing
> Keith> the case of `tokstart' -- which can easily be removed because we
> Keith> already have a temporary buffer that is used for this.]
>
> I think it's somewhat wrong to do this stuff in the parser anyhow.
> Ideally the symbol table ought to know that pascal is case-insensitive.
> I think we faced this with Fortran as well.
Case insensitive symbols should be supported (originally written for Fortran)
since:
commit 5b7743a275e4610fe6ea57f0c61e317490ee6854
Date: Wed Apr 27 20:03:03 2011 +0000
Case insensitive lookups implementation.
(+about one fallout later)
While f_language_defn has case_sensitive_off
I see that pascal_language_defn has case_sensitive_on.
At https://en.wikipedia.org/wiki/Pascal_%28programming_language%29#Hello_world
I read
Letter case is ignored in Pascal source.
so I think pascal_language_defn really should use case_sensitive_off.
Jan