This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Regression for gdb.pascal/* [Re: [RFA 4/4] Constify parse_linesepc]
- From: Tom Tromey <tromey at redhat dot com>
- To: Keith Seitz <keiths at redhat dot com>
- Cc: "gdb-patches\ at sourceware dot org ml" <gdb-patches at sourceware dot org>, Sergio Durigan Junior <sergiodj at redhat dot com>, Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Date: Thu, 17 Oct 2013 14:51:55 -0600
- Subject: Re: Regression for gdb.pascal/* [Re: [RFA 4/4] Constify parse_linesepc]
- Authentication-results: sourceware.org; auth=none
- References: <5249C987 dot 50809 at redhat dot com> <87d2no4uim dot fsf at fleche dot redhat dot com> <524BA344 dot 2070802 at redhat dot com> <20131016095743 dot GA17072 at host2 dot jankratochvil dot net> <m3zjq8hnub dot fsf at redhat dot com> <m3vc0wg4yg dot fsf at redhat dot com> <52602A08 dot 4020705 at redhat dot com>
>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:
Keith> There are two little sections of code, though, which violate
Keith> const-ness of the input, and I've removed those, since they don't
Keith> seem necessary. [This is the two loops that deal with changing
Keith> the case of `tokstart' -- which can easily be removed because we
Keith> already have a temporary buffer that is used for this.]
I think it's somewhat wrong to do this stuff in the parser anyhow.
Ideally the symbol table ought to know that pascal is case-insensitive.
I think we faced this with Fortran as well.
Keith> [Perhaps Pierre knows? It was added here:
Definitely need a reply from Pierre...
Keith> - for (i = 0; i <= namelen; i++)
Keith> - {
Keith> - if ((tokstart[i] >= 'a' && tokstart[i] <= 'z'))
Keith> - tokstart[i] -= ('a'-'A');
Keith> - }
Not your problem, Keith, but there's other code in that file that ought
to be using the ctypes macros instead of this stuff.
Tom