This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
RE: [PATCH v16 3/5] 'add-symbol-file' should update the current target sections.
- From: "Blanc, Nicolas" <nicolas dot blanc at intel dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Tue, 15 Oct 2013 13:37:24 +0000
- Subject: RE: [PATCH v16 3/5] 'add-symbol-file' should update the current target sections.
- Authentication-results: sourceware.org; auth=none
- References: <1381148820-21890-1-git-send-email-nicolas dot blanc at intel dot com> <1381148820-21890-4-git-send-email-nicolas dot blanc at intel dot com> <874n8o6f66 dot fsf at fleche dot redhat dot com>
Thanks for the input. I am implementing your suggestions and will update the patch series next week.
> Nicolas> +static void
> Nicolas> +add_target_sections_of_objfile (struct objfile *objfile)
>
> I'd like it better, I think, if some of the code in this function were either moved to exec.c alongside the other target_sections-manipulating functions, or just used them directly somehow.
I rewrote add_target_section_of_objfile using add_target_sections. The new code needs to construct on the heap a temporary array of target sections for the sole purpose of
calling add_target_sections. This is not as neat as the original code in my view. I would prefer moving add_target_sections_of_objfile to exec.c. Would this be ok with you?
Regards,
Nicolas
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Christian Lamprechter, Hannes Schwaderer, Douglas Lusk
Registergericht: Muenchen HRB 47456
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052