This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v16 3/5] 'add-symbol-file' should update the current target sections.
- From: Tom Tromey <tromey at redhat dot com>
- To: Nicolas Blanc <nicolas dot blanc at intel dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Thu, 10 Oct 2013 14:31:45 -0600
- Subject: Re: [PATCH v16 3/5] 'add-symbol-file' should update the current target sections.
- Authentication-results: sourceware.org; auth=none
- References: <1381148820-21890-1-git-send-email-nicolas dot blanc at intel dot com> <1381148820-21890-4-git-send-email-nicolas dot blanc at intel dot com>
>>>>> "Nicolas" == Nicolas Blanc <nicolas.blanc@intel.com> writes:
Nicolas> 2013-17-06 Nicolas Blanc <nicolas.blanc@intel.com>
Nicolas> * symfile.c (add_target_sections_of_objfile): New function.
Nicolas> (add_symbol_file_command): Update the current target sections.
Nicolas> (symfile_free_objfile): New function.
Nicolas> (_initialize_symfile): Attach observer for free_objfile.
Could you explain this one a bit?
Nicolas> +static void
Nicolas> +add_target_sections_of_objfile (struct objfile *objfile)
I'd like it better, I think, if some of the code in this function were
either moved to exec.c alongside the other target_sections-manipulating
functions, or just used them directly somehow.
Nicolas> + if (objfile->flags & OBJF_USERLOADED)
Needs an explicit "!= 0".
Tom