This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Always include defs.h first.

From: Pedro Alves <palves at redhat dot com>
To: Joel Brobecker <brobecker at adacore dot com>
Cc: Doug Evans <dje at google dot com>, gdb-patches at sourceware dot org
Date: Thu, 08 Nov 2012 18:50:15 +0000
Subject: Re: [PATCH] Always include defs.h first.
References: <20121107201107.25258.47267.stgit@brno.lan> <CADPb22QMBu5e5Vrxzm6aehYNnD2cBbiacb_STeZPKa7i-rpGiQ@mail.gmail.com> <509BE290.4000104@redhat.com> <CADPb22R1+-LVsre62Mm6HJgpiR+4KLktskMvcZG4nYESfvVMwQ@mail.gmail.com> <20121108183842.GM5103@adacore.com>

On 11/08/2012 06:38 PM, Joel Brobecker wrote:
> [I agree consistency is good]
> 
>> Note that gdbserver doesn't have defs.h and lots of files in common/ do the
>>
>> #ifdef GDBSERVER
>> #include "server.h"
>> #else
>> #include "defs.h"
>> #endif
> 
> Perhaps we should rename server.h into defs.h? Or move defs.h to
> common?

I agree with adding a defs.h to gdbserver.
defs.h depends on bfd and has lots of gdb-specifics, so no
good for gdbserver as is.

-- 
Pedro Alves

References:
- [PATCH] Always include defs.h first.
  - From: Pedro Alves
- Re: [PATCH] Always include defs.h first.
  - From: Doug Evans
- Re: [PATCH] Always include defs.h first.
  - From: Pedro Alves
- Re: [PATCH] Always include defs.h first.
  - From: Doug Evans
- Re: [PATCH] Always include defs.h first.
  - From: Joel Brobecker

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]