This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Always include defs.h first.

From: Joel Brobecker <brobecker at adacore dot com>
To: Doug Evans <dje at google dot com>
Cc: Pedro Alves <palves at redhat dot com>, gdb-patches at sourceware dot org
Date: Thu, 8 Nov 2012 10:38:42 -0800
Subject: Re: [PATCH] Always include defs.h first.
References: <20121107201107.25258.47267.stgit@brno.lan> <CADPb22QMBu5e5Vrxzm6aehYNnD2cBbiacb_STeZPKa7i-rpGiQ@mail.gmail.com> <509BE290.4000104@redhat.com> <CADPb22R1+-LVsre62Mm6HJgpiR+4KLktskMvcZG4nYESfvVMwQ@mail.gmail.com>

[I agree consistency is good]

> Note that gdbserver doesn't have defs.h and lots of files in common/ do the
> 
> #ifdef GDBSERVER
> #include "server.h"
> #else
> #include "defs.h"
> #endif

Perhaps we should rename server.h into defs.h? Or move defs.h to
common?

-- 
Joel

Follow-Ups:
- Re: [PATCH] Always include defs.h first.
  - From: Pedro Alves

References:
- [PATCH] Always include defs.h first.
  - From: Pedro Alves
- Re: [PATCH] Always include defs.h first.
  - From: Doug Evans
- Re: [PATCH] Always include defs.h first.
  - From: Pedro Alves
- Re: [PATCH] Always include defs.h first.
  - From: Doug Evans

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]