This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix mi "-var-create" regression

>>>>> "Luis" == Luis Machado <lgustavo@codesourcery.com> writes:

Luis> 2012-10-15  Luis Machado  <lgustavo@codesourcery.com>
Luis> 	* value.c (value_actual_type): Check for TYPE_CODE_STRUCT
Luis> 	target types.

Luis> 	testsuite/
Luis> 	* mi-var-create-rtti.c: New file.
Luis> 	* mi-var-create-rtti.exp: New file.

This looks good to me.  One tiny nit:

Luis> Index: gdb/gdb/testsuite/gdb.mi/mi-var-create-rtti.exp
Luis> +    return -1;

No need for a ";" here.

Ok with this change.

thanks,
Tom
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]