This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix mi "-var-create" regression

From: Tom Tromey <tromey at redhat dot com>
To: lgustavo at codesourcery dot com
Cc: Joel Brobecker <brobecker at adacore dot com>, gdb-patches at sourceware dot org
Date: Wed, 17 Oct 2012 19:13:20 -0600
Subject: Re: [PATCH] Fix mi "-var-create" regression
References: <5075D4FD.9050900@mentor.com> <20121014171805.GB3050@adacore.com> <507BFF97.2000900@codesourcery.com>

>>>>> "Luis" == Luis Machado <lgustavo@codesourcery.com> writes:

Luis> +	  && TYPE_CODE (TYPE_TARGET_TYPE (result)) != TYPE_CODE_VOID)

On further reflection, I have a question and a comment.

First, perhaps instead of excluding void* here, we should only allow
pointers to structs.  That is the only case that has RTTI anyhow.  What
do you think?

Also, I think this needs a check_typedef around TYPE_TARGET_TYPE.

Tom

Follow-Ups:
- Re: [PATCH] Fix mi "-var-create" regression
  - From: Luis Machado
- Re: [PATCH] Fix mi "-var-create" regression
  - From: Luis Machado

References:
- [PATCH] Fix mi "-var-create" regression
  - From: Luis Gustavo
- Re: [PATCH] Fix mi "-var-create" regression
  - From: Joel Brobecker
- Re: [PATCH] Fix mi "-var-create" regression
  - From: Luis Machado

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]