Re: RFA: probable rs6000-aix-tdep.c bug found by clang

[Pedro Alves <palves at redhat dot com>]

On 10/18/2012 04:33 PM, Joel Brobecker wrote:
>>>> 	* rs6000-aix-tdep.c (rs6000_aix_osabi_sniffer): Remove extraneous
>>>> 	semicolon.
>>
>> I suspect this is the root cause of PR8966 (AIX 5.1 single_step configuration
>> is broken).  http://sourceware.org/bugzilla/show_bug.cgi?id=8966
>>
>> We're always returning the _UNKNOWN osabi, so this is unreachable:
> 
> On the contrary, I think we always returned the AIX osabi.

Duh.  You're right.

I now notice the PR predates the patch that added this (a8cfed2a), and it seems the
patch was meant to fix exactly that single-step issue in the PR.  So I guess we
could close it.

Searching bugzilla for aix finds a handful of PRs, and most looks quite old.  I'd be
nice to give them a little triage love.  :-)

>>> So, isn't rs6000_aix_osabi_sniffer going to be called if, and only
>>> if, the bfd has a bfd_target_xcoff_flavour, thus making the check
>>> superfluous?
>>
>> Sure looks like it.
> 
> OK - I will take care of removing the condition and simplifying
> the function.

-- 
Pedro Alves