This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RFA: probable rs6000-aix-tdep.c bug found by clang


Here is another patch for a bug found by clang.

rs6000-aix-tdep.c:rs6000_aix_osabi_sniffer has an extraneous ";" that
makes the initial "if" irrelevant.

Based on indentation and logic I think that the fix is to remove the ";".
However, I have no decent way to test this and would appreciate someone
else looking at it.

Tom

2012-10-17  Tom Tromey  <tromey@redhat.com>

	* rs6000-aix-tdep.c (rs6000_aix_osabi_sniffer): Remove extraneous
	semicolon.

diff --git a/gdb/rs6000-aix-tdep.c b/gdb/rs6000-aix-tdep.c
index 59cfa73..749c109 100644
--- a/gdb/rs6000-aix-tdep.c
+++ b/gdb/rs6000-aix-tdep.c
@@ -723,7 +723,7 @@ static enum gdb_osabi
 rs6000_aix_osabi_sniffer (bfd *abfd)
 {
   
-  if (bfd_get_flavour (abfd) == bfd_target_xcoff_flavour);
+  if (bfd_get_flavour (abfd) == bfd_target_xcoff_flavour)
     return GDB_OSABI_AIX;
 
   return GDB_OSABI_UNKNOWN;


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]