This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] MI telnet service

From: Gary Benson <gbenson at redhat dot com>
To: "Abid, Hafiz" <Hafiz_Abid at mentor dot com>
Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
Date: Thu, 12 Jul 2012 16:08:19 +0100
Subject: Re: [patch] MI telnet service
References: <EB3B29AD43CA924DA27099BC8519237629DF36@EU-MBX-03.mgc.mentorg.com> <20120712131930.GG29236@redhat.com> <EB3B29AD43CA924DA27099BC8519237629DFEA@EU-MBX-03.mgc.mentorg.com>

Abid, Hafiz wrote:
> Gary Benson wrote:
> > > diff -N gdb/testsuite/gdb.mi/mi-telnet.c
> > > --- /dev/null	1 Jan 1970 00:00:00 -0000
> > > +++ gdb/testsuite/gdb.mi/mi-telnet.c	12 Jul 2012 10:35:17 -0000
> > 
> > The indentation in this file is completely wrong.  There's also
> > a lot of missing space before '(' for function calls and missing
> > space after casts.
> 
> I thought we are not required to follow the convention in the test
> program source.

Ah, possibly.  Perhaps someone more familiar could comment?

> Thanks for reviewing.

No problem :)

Cheers,
Gary

-- 
http://gbenson.net/

References:
- [patch] MI telnet service
  - From: Abid, Hafiz
- Re: [patch] MI telnet service
  - From: Gary Benson
- RE: [patch] MI telnet service
  - From: Abid, Hafiz

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]